Skip to content

DPL Analysis: write HistogramRegistry incrementally#14646

Merged
ktf merged 2 commits intoAliceO2Group:devfrom
ktf:pr14646
Sep 30, 2025
Merged

DPL Analysis: write HistogramRegistry incrementally#14646
ktf merged 2 commits intoAliceO2Group:devfrom
ktf:pr14646

Conversation

@ktf
Copy link
Member

@ktf ktf commented Sep 3, 2025 •
edited
Loading

This should reduce big spikes at the end of the processing when a large
HistogramRegistry is serialised.

Stack created with Sapling. Best reviewed with ReviewStack.

@ktf ktf requested a review from a team as a code owner September 3, 2025 11:14
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

alibuild commented Sep 4, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for daa8075 at 2025-09-18 15:18:

## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/7e6f7431dfd5802267616562ce8df00fe0b99938/slc9_x86-64/o2checkcode/1.0-local328/etc/modulefiles
++ cat
--

Full log here.

@ktf ktf force-pushed the pr14646 branch 3 times, most recently from 241ef6e to d20604b Compare September 22, 2025 13:43
@alibuild
Copy link
Collaborator

alibuild commented Sep 22, 2025

Error while checking build/O2/fullCI_slc9 for d20604b at 2025-09-22 19:11:

++ cp /sw/slc9_x86-64/O2/14646-slc9_x86-64-local1/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/14646-slc9_x86-64/0
++ [[ -e /sw/SOURCES/O2/14646-slc9_x86-64/0/CMakeLists.txt ]]

Full log here.

ktf added 2 commits September 25, 2025 11:34
@ktf
DPL: allow closing a signpost interval with an error
5336eed 
The error will be printed regardless of the signposts being enabled.

In case the signposts are actually enabled, the error will be the closing
message of the signpost interval.

In case the signposts are not enabled, the error will be printed as a standard error.
@ktf
DPL Analysis: write HistogramRegistry incrementally
18ce36b 
This should reduce big spikes at the end of the processing when a large
HistogramRegistry is serialised.
@ktf ktf mentioned this pull request Sep 25, 2025
Merged
@ktf ktf merged commit 7948f41 into AliceO2Group:dev Sep 30, 2025
17 checks passed
@ktf ktf deleted the pr14646 branch September 30, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ktf @alibuild